Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containerd Project Security Self-Assessment - Security Pals #1202

Merged
merged 19 commits into from
Oct 23, 2024
Merged

Containerd Project Security Self-Assessment - Security Pals #1202

merged 19 commits into from
Oct 23, 2024

Conversation

smallfoot47
Copy link
Contributor

@smallfoot47 smallfoot47 commented Dec 8, 2023 •
edited
Loading

Containerd Project Self-Assessment

Nathan Smith
Sunny Li
Swati Baleri
Vivek Radhakrishnan

Created and added first draft for OpenMetrics Project Security Self-Assessment.
Please feel free to share your feedback on the security self-assessment.

@netlify Netlify
Copy link

netlify bot commented Dec 8, 2023 •
edited
Loading

✅ Deploy Preview for tag-security ready!

Name Link
🔨 Latest commit 908bf8c
🔍 Latest deploy log https://app.netlify.com/sites/tag-security/deploys/67192e5d3490f300089d8adb
😎 Deploy Preview https://deploy-preview-1202--tag-security.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eddie-knight
Copy link
Collaborator

Hi there! I'm just starting to take a look at this, and I noticed that your pull request name isn't very descriptive.

If you take a look at the Pull Requests page, you'll see that the pile can be a lot easier to navigate if we all use descriptive titles. That'll help reviewers move more quickly, and also it's a great practice to follow when you're doing future work on platforms like GitHub/GitLab/Bitbucket/etc.

Instead of Group 27 self assessment a better alternative might be containerd self-assessment

@eddie-knight
Copy link
Collaborator

I also noticed the DCO check is failing.

You can look at the checks section of the PR (I believe it should always be below the last comment) and look for a red X highlighting the failed check. In this case, you can click Details for more information about how to get that check passing.
Screenshot 2023-12-08 at 8 35 18 AM

@smallfoot47 smallfoot47 changed the title Group 27 Self Assessment containerd self-assessment Dec 11, 2023
@smallfoot47 smallfoot47 changed the title containerd self-assessment Added Containerd Project Security Self-Assessment Dec 11, 2023
@smallfoot47 smallfoot47 changed the title Added Containerd Project Security Self-Assessment Containerd Project Security Self-Assessment Dec 11, 2023
@smallfoot47 smallfoot47 changed the title Containerd Project Security Self-Assessment Containerd Project Security Self-Assessment - Security Pals Dec 11, 2023
eddie-knight
eddie-knight reviewed Dec 12, 2023
View reviewed changes
assessments/Open_and_Secure_Early_Access.pdf Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that something got wonky with the commit history here. Same with the _index.md file linked below. Please check your history and clean it up accordingly.

ragashreeshekar
ragashreeshekar suggested changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@ragashreeshekar ragashreeshekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @SassyQuatch47 and team, appreciate the efforts.
I have completed first pass of review and left a few comments on section that needs your attention. Please feel free to reach out here or on slack for any questions and clarifications.

Containerd/self-assessment.md Outdated Show resolved Hide resolved
Containerd/self-assessment.md Outdated Show resolved Hide resolved
Containerd/self-assessment.md Outdated Show resolved Hide resolved
dependabot bot and others added 5 commits December 14, 2023 18:20
@dependabot @Nate-Smithline
Bump postcss and autoprefixer in /website/themes/docsy/userguide (cnc…
0ee9a48 
…f#1118)

Bumps [postcss](https://github.com/postcss/postcss) to 8.4.31 and updates ancestor dependency [autoprefixer](https://github.com/postcss/autoprefixer). These dependencies need to be updated together.

Updates `postcss` from 7.0.39 to 8.4.31
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@7.0.39...8.4.31)

Updates `autoprefixer` from 9.5.0 to 10.4.16
- [Release notes](https://github.com/postcss/autoprefixer/releases)
- [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md)
- [Commits](postcss/autoprefixer@9.5.0...10.4.16)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: indirect
- dependency-name: autoprefixer
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Nate-Smithline <[email protected]>
@dependabot @Nate-Smithline
Bump postcss from 8.4.20 to 8.4.31 in /website (cncf#1120)
513487a 
Signed-off-by: Nate-Smithline <[email protected]>
@Nate-Smithline @smallfoot47 @sunnnnyli
Created Self-Assessment of Containerd Project
8673238 
Signed-off-by: Nate-Smithline <[email protected]>
Co-authored-by: Vivek Radhakrishnan <[email protected]>
Co-authored-by: Swati Baleri <[email protected]>
Co-authored-by: Sunny Li <[email protected]>
Signed-off-by: Nate-Smithline <[email protected]>
@nomnomninja @Nate-Smithline
Removed template text and added more information for related vendors
248d6e2 
Signed-off-by: nomnomninja <[email protected]>
Signed-off-by: Nate-Smithline <[email protected]>
@Nate-Smithline
fixed first comment and added more details on who authored the doc
16303bf 
Signed-off-by: Nate-Smithline <[email protected]>
@tuminoid tuminoid mentioned this pull request Jan 23, 2024
Closed
@ragashreeshekar
Copy link
Contributor

@SassyQuatch47 Kindly address the pending suggestions. We (maintainers) do not have the permissions to update the PR hence we look forward to your updates. In the event it is not feasible, feel free to extend the permissions to us and we are happy to make the updates on your behalf. Thanks!

@smallfoot47
Copy link
Contributor Author

@SassyQuatch47 Kindly address the pending suggestions. We (maintainers) do not have the permissions to update the PR hence we look forward to your updates. In the event it is not feasible, feel free to extend the permissions to us and we are happy to make the updates on your behalf. Thanks!

Hi @ragashreeshekar , I apologize for the delay. We have given you permissions to update this PR. If any further issues come up, do let us know and we'd be happy to help!

eddie-knight
eddie-knight approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@eddie-knight eddie-knight left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ragashreeshekar It looks like all of your changes were applied— can you please confirm and resolve the requested change?

@eddie-knight eddie-knight merged commit b9132a0 into cncf:main Oct 23, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torinvdb torinvdb torinvdb left review comments

@sublimino sublimino sublimino left review comments

@Nate-Smithline Nate-Smithline Nate-Smithline approved these changes

@eddie-knight eddie-knight eddie-knight approved these changes

@ragashreeshekar ragashreeshekar ragashreeshekar approved these changes

@mlieberman85 mlieberman85 Awaiting requested review from mlieberman85

@PushkarJ PushkarJ Awaiting requested review from PushkarJ

@ultrasaurus ultrasaurus Awaiting requested review from ultrasaurus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@smallfoot47 @eddie-knight @ragashreeshekar @sublimino @torinvdb @Nate-Smithline @nomnomninja @sunnnnyli @JustinCappos