Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add in-toto governance review #740

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add in-toto governance review #740

wants to merge 4 commits into from

Conversation

xmulligan
Copy link
Contributor

fixes #733

@xmulligan
add in-toto governance review
97dfc91 
Signed-off-by: Bill Mulligan <[email protected]>
jberkus
jberkus requested changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@jberkus jberkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny correction.

governance/assessments/projects/it-toto/2024-10-31.md Outdated Show resolved Hide resolved
@xmulligan @jberkus
spelling and grammar
d47153a 
Co-authored-by: Josh Berkus <[email protected]>
Signed-off-by: Bill Mulligan <[email protected]>
@jberkus jberkus added wg/governance needs-liaison-approval Requires approval from TOC liaisons before merging labels Nov 1, 2024
TheFoxAtWork
TheFoxAtWork approved these changes Nov 2, 2024
View reviewed changes
Copy link
Contributor

@TheFoxAtWork TheFoxAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small spelling change and enhancement to the text.

governance/assessments/projects/it-toto/2024-10-31.md Outdated Show resolved Hide resolved
@xmulligan @TheFoxAtWork
spelling and wording suggestions
c299bc0 
Co-authored-by: Emily Fox <[email protected]>
Signed-off-by: Bill Mulligan <[email protected]>
@jberkus
Copy link
Contributor

jberkus commented Nov 14, 2024

@TheFoxAtWork @dims @dzolotusky ready for your approval.

trishankatdatadog
trishankatdatadog reviewed Nov 21, 2024
View reviewed changes
Copy link

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this!

Just commenting on minor typos in this round 🙂

governance/assessments/projects/it-toto/2024-10-31.md Outdated Show resolved Hide resolved
governance/assessments/projects/it-toto/2024-10-31.md Outdated Show resolved Hide resolved
governance/assessments/projects/it-toto/2024-10-31.md Outdated Show resolved Hide resolved
governance/assessments/projects/it-toto/2024-10-31.md Outdated Show resolved Hide resolved
governance/assessments/projects/it-toto/2024-10-31.md Outdated Show resolved Hide resolved
governance/assessments/projects/it-toto/2024-10-31.md Outdated Show resolved Hide resolved
@xmulligan @trishankatdatadog
fix: spelling
2ab8b42 
Co-authored-by: Trishank Karthik Kuppusamy <[email protected]>
Signed-off-by: Bill Mulligan <[email protected]>
@xmulligan
Copy link
Contributor Author

Thanks, just updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheFoxAtWork TheFoxAtWork TheFoxAtWork approved these changes

@dims dims dims approved these changes

@jberkus jberkus Awaiting requested review from jberkus

@trishankatdatadog trishankatdatadog Awaiting requested review from trishankatdatadog

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
needs-liaison-approval Requires approval from TOC liaisons before merging wg/governance
Projects
TAG Contributor Strategy Project Board
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Governance Review]: in-toto
5 participants
@xmulligan @jberkus @dims @trishankatdatadog @TheFoxAtWork