Number as float #372
Merged
Number as float #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,10 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
This script does not relate to the original issue. Can you split this PR and add another PR with a information what this script is for?
| return nil, fmt.Errorf("number: unknown type %T", t) | ||
|
|
||
| case []uint8: // mysql | ||
| res, _ = strconv.ParseFloat(string(t), 64) |
There was a problem hiding this comment.
It's not a good idea to ignore parsing errors. At least, please log a warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces distinction between types
numberandintegerto conform to JSON spec where number is double-precision floating-point.See #359.