[Workers] Add Notes about Type Expections about Worker's Socket API #9118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadlypants1973
changed the title
|
@jasnell can you review this PR so we can merge it? Thanks. |
jasnell
approved these changes
Oct 3, 2023
deadlypants1973
approved these changes
Oct 3, 2023
WalshyDev
force-pushed
the
dev-workersocketapitype
branch
from
3b0d3c1
to
db1a8d7
Compare
irvinebroque
reviewed
Oct 9, 2023
|
Do we need to document this in https://sockets-api.proposal.wintercg.org/ ? @dom96 @jasnell |
dom96
reviewed
Oct 10, 2023
content/workers/runtime-apis/streams/writablestreamdefaultwriter.md
Outdated
Show resolved
Hide resolved
I think so. I created an issue for this. wintercg/proposal-sockets-api#22 |
Co-authored-by: Dominik Picheta <[email protected]>
irvinebroque
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the documentation about Worker's Stream API do not mention that the
write()may accept fewer kinds of type thananyand however, it will throw an exception if the type is unexpected. This exception is more likely to be ignored in websocket's event handler since it is not an asynchronize function.(See also: cloudflare/workerd#688)