-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entangling Capability and Expressibility #92
Conversation
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Hello @stroblme! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-06-06 08:58:40 UTC |
Signed-off-by: lc3267 <[email protected]>
ignoring, because E203 is not PEP compliant |
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Signed-off-by: lc3267 <[email protected]>
Although there is some randomness in the calculation, you should be able to reproduce the results from your source, correct? Have you done that? It would be a nice way to check your implementation. |
Good point, will add that! |
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Added some tests to verify reasonable values for expressibility and entangling capability as mentioned in #42 |
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Melvin!
Like the additions you made!
Go for it, buddy!
This PR resolved #47 and #37.
The implementation includes:
After some evaluations and testing: