Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Pangu.kt for all settings #585

Merged
merged 1 commit into from
Aug 21, 2023
Merged

feat: use Pangu.kt for all settings #585

merged 1 commit into from
Aug 21, 2023

Conversation

std-microblock
Copy link
Collaborator

@std-microblock std-microblock commented Aug 20, 2023 •
edited
Loading

需要测试，应在 #582 后合并

close #423

@std-microblock
feat: implement Pangu.kt
a3f0dd7 
docs: improve description of pangu

feat: use pangu for all setting title and summary

style: rename pangu to pangu_spacing
@std-microblock std-microblock mentioned this pull request Aug 21, 2023
Closed
@cinit cinit merged commit 9ccb840 into cinit:main Aug 21, 2023
2 checks passed
@Cryolitia
Copy link
Collaborator

代码质量过低，几乎没有可读性，IDE也无法针对正则表达式给出正确的上色

应使用 https://kotlinlang.org/docs/coding-conventions.html#strings 而不是转义符号

应使用 https://www.runoob.com/w3cnote/reg-lookahead-lookbehind.html 而不是 $1$2

@NextAlone
Copy link
Collaborator

@Cryolitia 好

@NextAlone
Copy link
Collaborator

@Cryolitia 怎么默认开启？差评

@Cryolitia
Copy link
Collaborator

Cryolitia commented Mar 20, 2024 •
edited
Loading

怎么还是用的 java.util.regex 而不是 kotlin.text.Regex ，不会Kotlin就老老实实写Java没人会说什么，别写一堆Java味的Kotlin屎出来

@NextAlone
Copy link
Collaborator

@Cryolitia 👍👍

@std-microblock
Copy link
Collaborator Author

@Cryolitia 这么有攻击性？我kt和java都不会啊，这么要代码质量你自己改改，我确实不会

@std-microblock
Copy link
Collaborator Author

@Cryolitia 这段是从原版js翻译的，我是懒得改

@Cryolitia
Copy link
Collaborator

Cryolitia commented Mar 21, 2024 •
edited
Loading

@MicroCBer 这句话是我有攻击性，我向你道歉。但是我确实不太喜欢你的代码风格，你等我自己去把Android Studio下回来。

@Cryolitia
Copy link
Collaborator

@Cryolitia 这段是从原版js翻译的，我是懒得改

如果是直接从JavaScript翻译的建议下次在PR中明确指出以便其他开发者加以关注，否则就会有人TL;DR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[功能请求] 添加盘古功能
4 participants
@std-microblock @Cryolitia @NextAlone @cinit