RFC: Dry run improvements #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to slow down the overall process and ensure that when you run these commands with --dry-run, you as a user can more easily understand exactly all of the mutable steps that are being made. There's a slight weakness here, which is that any change that the binary makes directly in Go will not be covered by this. But it covers a fair amount (git invocations, sending PRs). Signed-off-by: Joe Stringer <[email protected]>
In dry-run mode, we shouldn't be making any mutable changes, so it should be safe to report errors and then continue to the next step. Example use case: The first stage of step 1 failed due to release blockers being opened. I wanted to _also_ find out about the status of the vulnerability scanners, but previously the command would stop before the latter stage. Signed-off-by: Joe Stringer <[email protected]>
|
I'm a little bit paranoid about dry run mode due to #245 , but this might be going too far. I found it quite useful while preparing #244 since this is the first time we're using this tool for a minor release, but I'm also not entirely convinced that this is the right UX. We could adopt all, none, or a subset of the proposals in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for more details: