Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running the release tool with --dry-run should not post PRs #245

Open
joestringer opened this issue Jul 24, 2024 · 1 comment
Open

Running the release tool with --dry-run should not post PRs #245

joestringer opened this issue Jul 24, 2024 · 1 comment

Comments

@joestringer
Copy link
Member

The flag says:

      --dry-run                   If enabled, it will not perform irreversible operations into GitHub such as: syncing GH projects, pushing tags. All changes that are done locally as well as creating and pushing PRs are also considered reversible and therefore not affected by this flag's value.

Even if posting a PR is reversible, it is surprising for the tool to push a PR when --dry-run is enabled. For instance, I was running this script to locally inspect what the tool would generate, and then it opened a PR on cilium/cilium.

@joestringer
Copy link
Member Author

I would typically expect a dry run to avoid all write operations. I think this is interesting in context of making changes to the filesystem since some of the steps do rely on filesystem changes in order to execute to the next step (for instance, calculating which commits were introduced since the last release).

This was referenced Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant