-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: use log/slog instead of golang.org/x/exp/slog #1182
Conversation
056d8d8
to
c1b81e0
Compare
The static check failure is due to golangci-lint being built with Go 1.20 and not Go 1.21 meaning it does not understand the new built-ins (
|
I'd prefer this option, given a golangci-lint release will happen later this week. We can still revert the Go 1.21.0 update if the golangci-lint release is delayed for some reason. |
Nice, v1.54.0 was just released: https://github.com/golangci/golangci-lint/releases/tag/v1.54.0. Let's trigger renovate to pick up the update. EDIT: I didn't want to wait on the bot and just pushed a commit to update golangci-lint. |
Signed-off-by: Robin Hahling <[email protected]>
Signed-off-by: Robin Hahling <[email protected]>
Now that we are using Go v1.21, we can use the `log/slog` from the standard library instead of the experimental package. Signed-off-by: Robin Hahling <[email protected]>
c1b81e0
to
5d422da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, thanks!
Now that we are using Go v1.21, we can use the
log/slog
from the standard library instead of the experimental package.This is a follow-up to #1108