Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninstall: Wait for the test namespace to be terminated #372

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

michi-covalent
Copy link
Contributor

Wait for the test namespace to be terminated when the --wait flag is
specified to avoid the situation where the next connectivity check fails
to deploy resources because the test namespace is in Terminating state.

Ref: #370

Signed-off-by: Michi Mutsuzaki [email protected]

@michi-covalent michi-covalent temporarily deployed to ci June 25, 2021 18:43 Inactive
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fastest turnaround time 🚀

install/uninstall.go Show resolved Hide resolved
@michi-covalent
Copy link
Contributor Author

rebasing to pick up #319

Wait for the test namespace to be terminated when the `--wait` flag is
specified to avoid the situation where the next connectivity check fails
to deploy resources because the test namespace is in Terminating state.

Fixes: #370

Signed-off-by: Michi Mutsuzaki <[email protected]>
@michi-covalent michi-covalent temporarily deployed to ci June 28, 2021 21:02 Inactive
@michi-covalent michi-covalent marked this pull request as ready for review June 28, 2021 21:37
@michi-covalent michi-covalent requested a review from a team as a code owner June 28, 2021 21:37
@michi-covalent michi-covalent merged commit 7c72164 into master Jun 28, 2021
@michi-covalent michi-covalent deleted the pr/michi/waitns branch June 28, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants