handle multiple failed status checks of same name #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chdsbd
commented
Oct 20, 2022
| app { | ||
| databaseId | ||
| } | ||
| workflowRun { |
There was a problem hiding this comment.
will be null if we don't have permission. We currently don't have access. We need to request new permissions
chdsbd
commented
Oct 20, 2022
| @@ -275,7 +275,22 @@ def review_status(reviews: List[PRReview]) -> PRReviewState: | |||
|
|
|||
|
|
|||
| def deduplicate_check_runs(check_runs: Iterable[CheckRun]) -> Iterable[CheckRun]: | |||
| check_run_map = {check_run.name: check_run for check_run in check_runs} | |||
| """ | |||
| unique by name, workflow databaseId, app | |||
There was a problem hiding this comment.
this is sooooooo complicated. GitHub Actions can create multiple check suites for the same workflow instead of just creating a new check run in the same check suite :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #688