update error message for closeTo

chaijs · Oct 8, 2024 · 45f8825 · 45f8825
1 parent 5abacf4
commit 45f8825
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/lib/chai/core/assertions.js b/lib/chai/core/assertions.js
@@ -3026,7 +3026,11 @@ function closeTo(expected, delta, msg) {
     , ssfi = flag(this, 'ssfi');
 
   new Assertion(obj, flagMsg, ssfi, true).is.numeric;
+  let message =  'A `delta` value is required for `closeTo`';
+  if (!delta) throw new AssertionError(flagMsg ? `${flagMsg}: ${message}` : message, undefined, ssfi);
   new Assertion(delta, flagMsg, ssfi, true).is.numeric;
+  message =  'A `expected` value is required for `closeTo`';
+  if (!delta) throw new AssertionError(flagMsg ? `${flagMsg}: ${message}` : message, undefined, ssfi);
   new Assertion(expected, flagMsg, ssfi, true).is.numeric;
 
   const abs = (x) => x < 0n ? -x : x;

diff --git a/test/assert.js b/test/assert.js
@@ -1916,7 +1916,7 @@ describe('assert', function () {
 
     err(function() {
       assert.closeTo(1.5, 1.0, undefined, 'blah');
-    }, "blah: expected undefined to be numeric");
+    }, "blah: A `delta` value is required for `closeTo`");
   });
 
   it('approximately', function(){
@@ -1947,7 +1947,7 @@ describe('assert', function () {
 
     err(function() {
       assert.approximately(1.5, 1.0, undefined, 'blah');
-    }, "blah: expected undefined to be numeric");
+    }, "blah: A `delta` value is required for `closeTo`");
   });
 
   it('sameMembers', function() {

diff --git a/test/expect.js b/test/expect.js
@@ -3306,7 +3306,7 @@ describe('expect', function () {
 
     err(function() {
       expect(1.5, 'blah').to.be.closeTo(1.0);
-    }, "blah: expected undefined to be numeric");
+    }, "blah: A `delta` value is required for `closeTo`");
   });
 
   it('approximately', function(){
@@ -3336,7 +3336,7 @@ describe('expect', function () {
 
     err(function() {
       expect(1.5).to.be.approximately(1.0);
-    }, "expected undefined to be numeric");
+    }, "A `delta` value is required for `closeTo`");
   });
 
   it('oneOf', function() {

diff --git a/test/should.js b/test/should.js
@@ -2768,7 +2768,7 @@ describe('should', function() {
 
     err(function() {
       (1.5).should.be.closeTo(1.0, undefined, 'blah');
-    }, "blah: expected undefined to be numeric");
+    }, "blah: A `delta` value is required for `closeTo`");
   });
 
   it('approximately', function(){
@@ -2792,7 +2792,7 @@ describe('should', function() {
 
     err(function() {
       (1.5).should.be.approximately(1.0);
-    }, "expected undefined to be numeric");
+    }, "A `delta` value is required for `closeTo`");
   });
 
   it('include.members', function() {