Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python 3 HTTP Status errors caused by RestClientUtils #88

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bizstatsai
Copy link

In cdap-authentication-clients/python/cdap_auth_client/rest_client_utils.py
python2 uses httplib

>>> import httplib as hl
>>> hl.OK
200
>>> type(hl.OK)
<type 'int'>

python3 uses http.client

>>> import http.client as hl
>>> hl.OK
<HTTPStatus.OK: 200>
>>> type(hl.OK)
<enum 'HTTPStatus'>
>>> hl.OK.value
200
>>> type(hl.OK.value)
<class 'int'>

To fix this we changed rest_client_utils.py#34 from

def verify_response_code(response_code):
    if response_code is hl.OK:
        LOG.debug("Success operation result code.")
        return
    else:
        RestClientUtils.check_status(response_code)

to

def verify_response_code(response_code):
    if (hl.__name__ is 'httplib' and response_code is hl.OK) or (hl.__name__ is 'http.client' and response_code is hl.OK.value):
        LOG.debug("Success operation result code.")
        return
    else:
        RestClientUtils.check_status(response_code)

In cdap-authentication-clients/python/cdap_auth_client/rest_client_utils.py
python2 uses httplib

>>> import httplib as hl
>>> hl.OK
200
>>> type(hl.OK)
<type 'int'>
python3 uses http.client

>>> import http.client as hl
>>> hl.OK
<HTTPStatus.OK: 200>
>>> type(hl.OK)
<enum 'HTTPStatus'>
>>> hl.OK.value
200
>>> type(hl.OK.value)
<class 'int'>
To fix this we changed rest_client_utils.py#34 from

def verify_response_code(response_code):
    if response_code is hl.OK:
        LOG.debug("Success operation result code.")
        return
    else:
        RestClientUtils.check_status(response_code)
to

def verify_response_code(response_code):
    if (hl.__name__ is 'httplib' and response_code is hl.OK) or (hl.__name__ is 'http.client' and response_code is hl.OK.value):
        LOG.debug("Success operation result code.")
        return
    else:
        RestClientUtils.check_status(response_code)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants