RocksDB: Check if C++ interface is exported by the system library #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shared Windows builds of RocksDB produce a .dll file that only dllexports the C interface of RocksDB, which will cause the config tests to use the system library but link will fail because the C++ symbols are undefined. This patch makes the config test link to the C++ interface to check if the system library exports the C++ symbols.
|
I forget -- the tests don't actually execute, right? They only get compiled and linked -- is that correct? |
|
Yes, they do not execute. I found some issues with this, which is why I converted to a draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared Windows builds of RocksDB produce a .dll file that only dllexports the C interface of RocksDB, which will cause the config tests to use the system library but link will fail because the C++ symbols are undefined.
This patch makes the config test link to the C++ interface to check if the system library exports the C++ symbols.