Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model quick cleanups #258

Open
6 tasks
dfsnow opened this issue Sep 6, 2024 · 2 comments
Open
6 tasks

Model quick cleanups #258

dfsnow opened this issue Sep 6, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation pipeline Code that glues all the model bits together

Comments

@dfsnow
Copy link
Member

dfsnow commented Sep 6, 2024

Just to get started:

  • Remove individual PIN-level report (superseded by PINVAL)
  • Cleanup analysis section resulting from Add descriptive stats for categorical variables #257
  • Add README section / docs on reports vs analyses
  • Considering moving some sections of the README into docs/
  • Remove CI calculations from the evaluate stage
  • Bump versions for pre-commit hooks and GitHub Actions
@dfsnow dfsnow added pipeline Code that glues all the model bits together documentation Improvements or additions to documentation labels Sep 6, 2024
@ccao-jardine
Copy link
Member

This is such a tiny nitpick, but while we're here, I'd also propose modifying how the model handles char_apts. Specifically, this blob in the ingest handles some recoding that I wonder might be handled more gracefully elsewhere in our architecture.

@ccao-jardine
Copy link
Member

ccao-jardine commented Sep 19, 2024

Notes from pre-2025 meeting:

  • terraform fix (fix error thrown from github action run)
  • params, multicard_yoy_cap which caps the yoy change for the smaller property: let's check this out, time permitting

Checklist for running 2025:

  • update years in params.yaml
  • need 2025 land rates (forward-fill land rates from prior tri, or create averages from existing data in ias?)
  • could be fun to try make the linear model really good, by testing some polynomials and removing some categorials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pipeline Code that glues all the model bits together
Projects
None yet
Development

No branches or pull requests

2 participants