tagging: ignore if cannot get lock

catalyst · Sep 10, 2024 · a035f35 · a035f35
1 parent 3002355
commit a035f35
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/classes/local/store/object_file_system.php b/classes/local/store/object_file_system.php
@@ -1187,8 +1187,9 @@ private function update_object(array $result): array {
      * External client must support tagging.
      *
      * @param string $contenthash file to sync tags for
+     * @return bool true if set tags, false if could not get lock.
      */
-    public function push_object_tags(string $contenthash) {
+    public function push_object_tags(string $contenthash): bool {
         if (!$this->get_external_client()->supports_object_tagging()) {
             throw new coding_exception("Cannot sync tags, external client does not support tagging.");
         }
@@ -1199,7 +1200,7 @@ public function push_object_tags(string $contenthash) {
 
         // No lock - just skip it.
         if (!$lock) {
-            throw new coding_exception("Could not get object lock");
+            return false;
         }
 
         try {
@@ -1227,6 +1228,7 @@ public function push_object_tags(string $contenthash) {
             throw $e;
         }
         $lock->release();
+        return true;
     }
 
     /**