Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo PR #8 #9

Open
cameron1729 opened this issue May 18, 2023 · 0 comments
Open

Undo PR #8 #9

cameron1729 opened this issue May 18, 2023 · 0 comments

Comments

@cameron1729
Copy link
Contributor

We had to create #8 due to MDL-78276

We can probably safely keep the weak equality check, but we might want to consider changing it back to strict equality check after MDL-78276 is integrated.

Note that MDL-78276 will only be fixed in master, 4.2, and 4.1 - but the regression is also present in 4.0. So we may want to have a separate 4.0 branch for this plugin, or simply drop support for 4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant