Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successful Reproduction of Anserini #2624

Merged
merged 4 commits into from
Oct 27, 2024
Merged

Conversation

pxlin-09
Copy link
Contributor

Hi all,
I am using a Mac Pro with M2 chip
jdk-21.0.5
mvn 3.9.9
python 3.9.6

some problems I encountered:

  1. tests error during maven build project
  2. Exception in thread "main" java.lang.SecurityException

Solution to problems

  1. use mvn clean package -DskipTests instead
  2. Add in pom.xml, maven-shade-plugin's configuration
    <filters>
    <filter>
    <artifact>*:*</artifact>
    <excludes>
    <exclude>META-INF/*.SF</exclude>
    <exclude>META-INF/*.DSA</exclude>
    <exclude>META-INF/*.RSA</exclude>
    </excludes>
    </filter>
    </filters>

@lintool
Copy link
Member

lintool commented Oct 26, 2024

@pxlin-09 Can you add (2) do your PR? i.e., the filters in maven-shade-plugin configuration.

@pxlin-09
Copy link
Contributor Author

@pxlin-09 Can you add (2) do your PR? i.e., the filters in maven-shade-plugin configuration.

done!

@lintool lintool merged commit 3bc1f8b into castorini:master Oct 27, 2024
1 check passed
@lintool
Copy link
Member

lintool commented Oct 27, 2024

Hi @pxlin-09 see #2625 - thanks for contributing the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants