Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the "--mem" long option is deprecated in favour of "--memory". Please… #4442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

themagiccog
Copy link

the "--mem" long option is deprecated in favour of "--memory". Please… update any scripts, etc.

Summary

the "--mem" long option is deprecated in favour of "--memory". Please… update any scripts, etc.

Changes

change from --mem to --memory

Testing

N/A

Possible Regressions

No

Checklist

  • Read the contributions page.
  • Submitted the CLA form, if you are a first time contributor.
  • The introduced changes are covered by unit and/or integration tests.

Notes

N/A

Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @themagiccog!

Thank you for the PR, there's more references to --mem in the code, would you mind making sure they are all updated?

Thank you!

Copy link
Author

@themagiccog themagiccog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good... Thanks

@themagiccog
Copy link
Author

You can proceed to merge.

Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still references and usage of --mem in the code, please address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants