Improve Generic Assay Meta performance #10386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dippindots
force-pushed
the
fix-10068
branch
from
fceca68
to
deef5c8
Compare
|
Overall this looks good and about ready to merge. I think fixing the failing test is all that is needed. |
|
@JREastonMarks Thanks for the review, didn't notice the test is failing here. Will address the failing test and update soon. |
dippindots
force-pushed
the
fix-10068
branch
from
deef5c8
to
46b6447
Compare
dippindots
force-pushed
the
fix-10068
branch
from
46b6447
to
9f2d603
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi @dippindots, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial Fix cBioPortal/icebox#570
Describe changes proposed in this pull request:
getGenericAssayAdditionalpropertiesByMolecularProfileId, this function will reduce the ids in the SQL query and in some cases (query that requires too much data), this can avoid the database crash because there are too many ids in the query.getGenericAssayAdditionalpropertiesByMolecularProfileIdis also been cached in the static cache, this will improve the fetching speed too