Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] Idiomatic formatting #1083

Merged
merged 8 commits into from
Nov 20, 2024
Merged

[C#] Idiomatic formatting #1083

merged 8 commits into from
Nov 20, 2024
+164 −70

Conversation

yowl
Copy link
Collaborator

@yowl yowl commented Nov 7, 2024

Generic types begin with T
Methods start with uppercase
some block { moved to own line.

draft as behind #1070

@jsturtevant jsturtevant mentioned this pull request Nov 8, 2024
Closed
silesmo
silesmo reviewed Nov 19, 2024
View reviewed changes
crates/csharp/src/lib.rs Outdated Show resolved Hide resolved
@silesmo
Copy link
Member

silesmo commented Nov 19, 2024

Marking this as ready for review as #1070 has now been merged.

@silesmo silesmo marked this pull request as ready for review November 19, 2024 16:14
silesmo
silesmo approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@silesmo silesmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The only thing potentially is if the TODO I commented on should be removed. So leaving it up to you @yowl If that is the case or not.

@yowl
Copy link
Collaborator Author

yowl commented Nov 20, 2024

Thanks for the review

@yowl yowl added this pull request to the merge queue Nov 20, 2024
Merged via the queue into bytecodealliance:main with commit 563956d Nov 20, 2024
25 checks passed
@yowl yowl deleted the cs-style branch November 20, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silesmo silesmo silesmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yowl @silesmo