pulley: Fix interpreter push/pop #9644
Open
+808
−689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Define loop-over-match and loop-with-tail-calls in separate files to make it more clear which is in which (and less `#[cfg]`) * Move per-opcode handlers to `interp.rs` outside of a macro invocation to get better native editor support (e.g. formatting, hints, etc). This is roughly intended to be perf-neutral but we don't have many automated benchmarks yet for Pulley so it's intended to profile later as well.
* Add stack-overflow checking to `push` and other decrements of `sp`. * Fix the up/down direction of push/pop (`push` goes down, `pop` goes up). * Fix the order of operation sin `push`, first decrement then write. * Move methods to `Interpreter` to use `ControlFlow` more heavily.
|
Review-wise this is stacked on #9629 |
Subscribe to Label Actioncc @fitzgen
This issue or pull request has been labeled: "pulley"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pushand other decrements ofsp.pushgoes down,popgoes up).push, first decrement then write.Interpreterto useControlFlowmore heavily.