Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasmparser: feature gate Wasm simd support #1903

Open
wants to merge 57 commits into
base: main
Choose a base branch
from
Open

wasmparser: feature gate Wasm simd support #1903

wants to merge 57 commits into from

Commits on Nov 12, 2024

  1. add for_each_simd_operator generator macro

    @Robbepop
    Robbepop committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    827b128 View commit details
    Browse the repository at this point in the history

  2. define SimdOperator enum

    @Robbepop
    Robbepop committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    5944fb9 View commit details
    Browse the repository at this point in the history

  3. add SimdOperator::operator_arity impl

    @Robbepop
    Robbepop committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    d3e99f0 View commit details
    Browse the repository at this point in the history

  4. add VisitSimdOperator trait definition

    @Robbepop
    Robbepop committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9698f97 View commit details
    Browse the repository at this point in the history

  5. define VisitSimdOperator delegates

    @Robbepop
    Robbepop committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    76557eb View commit details
    Browse the repository at this point in the history

  6. add benchmark NopVisit impl

    @Robbepop
    Robbepop committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    6adace1 View commit details
    Browse the repository at this point in the history

  7. add simd crate feature

    @Robbepop
    Robbepop committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    2fa11f2 View commit details
    Browse the repository at this point in the history

  8. add simd_visitor method to VisitOperator trait

    @Robbepop
    Robbepop committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    baa1de5 View commit details
    Browse the repository at this point in the history

  9. add VisitSimdOperator impl to OperatorFactory

    @Robbepop
    Robbepop committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    bb4a415 View commit details
    Browse the repository at this point in the history

  10. use VisitOperator::simd_visitor in BinaryReader::visit_operator

    @Robbepop
    Robbepop committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    df32e79 View commit details
    Browse the repository at this point in the history

  11. add lifetime to return value of simd_visitor method

    @Robbepop
    Robbepop committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    de0f049 View commit details
    Browse the repository at this point in the history

  12. add VisitSimdOperator impl for OperatorValidator

    @Robbepop
    Robbepop committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    efd1c0c View commit details
    Browse the repository at this point in the history

  13. add Operator::Simd variant

    @Robbepop
    Robbepop committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    26cc42d View commit details
    Browse the repository at this point in the history

  14. remove simd operators from for_each_operator macro

    @Robbepop
    Robbepop committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    ac2d6a8 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. adjust wasmprinter crate for simd crate feature

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    531240e View commit details
    Browse the repository at this point in the history

  2. enable wasmparser's simd feature by default

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    5c94737 View commit details
    Browse the repository at this point in the history

  3. fix trait impl signature

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    bfb354a View commit details
    Browse the repository at this point in the history

  4. add docs to wasmparser's simd crate feature

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e257fcb View commit details
    Browse the repository at this point in the history

  5. feature gate simd related code in wasmparser

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    eb3845d View commit details
    Browse the repository at this point in the history

  6. update docs for SimdOperator

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    77a33de View commit details
    Browse the repository at this point in the history

  7. add missing simd crate feature gates

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7439a1f View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into rf-feature-gate-simd

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    82412a5 View commit details
    Browse the repository at this point in the history

  9. move simd op validation down in file

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c373909 View commit details
    Browse the repository at this point in the history

  10. put simd specific operator validation in separate file

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    267808c View commit details
    Browse the repository at this point in the history

  11. add docs to for_each_simd_operator macro

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    28e15df View commit details
    Browse the repository at this point in the history

  12. move for_each_simd_operator macro into a separate file

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    faa8317 View commit details
    Browse the repository at this point in the history

  13. fix docs for VisitSimdOperator

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    6eef116 View commit details
    Browse the repository at this point in the history

  14. allow missing docs again for VisitSimdOperator 

    This is just like with VisitOperator trait.
    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    cc88460 View commit details
    Browse the repository at this point in the history

  15. add docs and example to VisitOperator::simd_visitor

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a703340 View commit details
    Browse the repository at this point in the history

  16. move visit_0xfd_operator into separate file 

    We do this to further improve compile times for when the `simd` crate feature is disabled.
    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e6614e0 View commit details
    Browse the repository at this point in the history

  17. apply rustftm

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3c9559c View commit details
    Browse the repository at this point in the history

  18. wasmprinter: fix remaining simd feature toggles

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a8f67fe View commit details
    Browse the repository at this point in the history

  19. apply rustfmt

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c9204e6 View commit details
    Browse the repository at this point in the history

  20. fix wasmparser benchmarks

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2755180 View commit details
    Browse the repository at this point in the history

  21. wasm-encoder: add simd support

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    accb113 View commit details
    Browse the repository at this point in the history

  22. apply rustfmt and avoid formatting some parts

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c87a791 View commit details
    Browse the repository at this point in the history

  23. wasm-mutate: fix compile errors

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7b0a04b View commit details
    Browse the repository at this point in the history

  24. apply rustfmt

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    76d4d6a View commit details
    Browse the repository at this point in the history

  25. fix dev-dependencies for wasm-mutate

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7c7eb46 View commit details
    Browse the repository at this point in the history

  26. add simd_visitor impl to NopVisitor

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    73fb3ba View commit details
    Browse the repository at this point in the history

  27. add missing VisitSimdOperator impl for WasmProposalValidator

    @Robbepop
    Robbepop committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a458b3a View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. mark doc example as compile_fail

    @Robbepop
    Robbepop committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8924923 View commit details
    Browse the repository at this point in the history

  2. add simd support for VisitConstOperator

    @Robbepop
    Robbepop committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8884f95 View commit details
    Browse the repository at this point in the history

  3. use wasmparser/simd in validate tool

    @Robbepop
    Robbepop committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    0beba9e View commit details
    Browse the repository at this point in the history

  4. add simd crate feature propagation to wasm-tools CLI tool

    @Robbepop
    Robbepop committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    351e169 View commit details
    Browse the repository at this point in the history

  5. wasm-smith: use wasmparser/simd crate feature

    @Robbepop
    Robbepop committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    04f34ab View commit details
    Browse the repository at this point in the history

  6. apply rustfmt

    @Robbepop
    Robbepop committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c419be7 View commit details
    Browse the repository at this point in the history

  7. feature gate simd_visitor impl

    @Robbepop
    Robbepop committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    5c1eeb4 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. unconditionally enable simd for wasmprinter

    @Robbepop
    Robbepop committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    cec6bb7 View commit details
    Browse the repository at this point in the history

  2. unconditionally enable simd for wasm-encoder

    @Robbepop
    Robbepop committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    1dfbf6e View commit details
    Browse the repository at this point in the history

  3. remove wasm-tools simd feature (enable by default)

    @Robbepop
    Robbepop committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    a98227f View commit details
    Browse the repository at this point in the history

  4. use macros generate for_each_operator macros 

    - This does not yet provide a for_each_operator macro in for !simd mode but that should be easily added.
- This is WIP in that is currently does not handle the documentation of the macros well. We might need to also generate the macro docs in the macros themselves.
    @Robbepop
    Robbepop committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    efa3d43 View commit details
    Browse the repository at this point in the history

  5. remove comment out line

    @Robbepop
    Robbepop committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    887a8cf View commit details
    Browse the repository at this point in the history

  6. put docs on the exported macros

    @Robbepop
    Robbepop committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    cbbc575 View commit details
    Browse the repository at this point in the history

  7. fix macro imports

    @Robbepop
    Robbepop committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    ba48386 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. fix bugs in generator macros

    @Robbepop
    Robbepop committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    6b9a883 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. improve compile times for macros

    @Robbepop
    Robbepop committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    91ddc75 View commit details
    Browse the repository at this point in the history