Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unfolded versions of the legacy (v3) exception-handling tests #1672

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

keithw
Copy link
Contributor

@keithw keithw commented Jul 14, 2024

The conclusion in #1653 & #1661 looks to be to support the legacy exception-handling instructions except for parsing their folded form in the text format. The proposal's tests use the folded form, so they can't be run directly.

This PR adds unfolded versions of the current legacy exception-handling tests (except for 7 assert_malformed directives that are commented out because of #1671).

(Context: I've been working on adding folding support to wasmprinter by annotating the for_each_operator macro with the category or arity of each instruction, with an automated test that the annotation matches the validator's behavior. So it would be helpful to have better test coverage of these instructions given that they'll be supported by the validator.)

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Also I think that as the motivation grows to add support for the legacy exceptions proposal I think it's worthwhile to reconsider re-adding the folded forms to the text parser if that would make testing and/or other constructs easier.

@alexcrichton alexcrichton added this pull request to the merge queue Jul 15, 2024
Merged via the queue into bytecodealliance:main with commit 1cdafa7 Jul 15, 2024
27 checks passed
@keithw keithw deleted the legacy-exceptions branch July 16, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants