Check possible overflow in aot memory boundary check #3920
Conversation
TianlongLiang
requested review from
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
| BUILD_OP(Add, offset_const, addr, offset1, "offset1"); | ||
|
|
||
| if (is_target_64bit && comp_ctx->enable_bound_check) { |
There was a problem hiding this comment.
Only when the memory is 64-bit (is_memory64 is true and target must be 64-bit) should we check the integer overflow: if memory is 32-bit, (1) if target is 32-bit, offset_const and addr are not extended to uint64, but integer overflow will be checked later, (2) if target is 64-bit, offset_const and addr are extended to uint64 and are no larger than UINT32_MAX, so integer overflow won't occur when adding them (the result is smaller than 8GB).
So how about if (is_memory64 && comp_ctx->enable_bound_check) {?
| BUILD_OP(Add, offset, bytes, max_addr, "max_addr"); | ||
|
|
||
| if (is_target_64bit && comp_ctx->enable_bound_check) { |
There was a problem hiding this comment.
Same as above, if the memory is 32-bit, here offset and bytes are already extended to u64, adding them won't lead to integer overflow. Had better change to if (is_memory64 && comp_ctx->enable_bound_check)?
No description provided.