add testcases for shared heap and fix POP_MEM_OFFSET of memory64 #3916
+197
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenLY1
force-pushed
the
dev_shared_heap
branch
2 times, most recently
from
ab65491
to
410df62
Compare
Signed-off-by: wenlingyun1 <[email protected]>
Signed-off-by: wenlingyun1 <[email protected]>
WenLY1
force-pushed
the
dev_shared_heap
branch
from
6ebcf4f
to
04f0bd1
Compare
WenLY1
requested review from
loganek,
lum1n0us,
no1wudi,
xujuntwt95329 and
yamt
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix POP_MEM_OFFSET of memory64:
When WAMR_BUILD_MEMORY64 is enabled but is_memory64 is false, if the addr is larger than 0x80000000 and the addr is directly converted to uint64 from int32, the result is wrong, as follows