Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[instantiation linking] create and import WASMMemoryInstance for aot #3887

Merged
merged 14 commits into from
Nov 20, 2024
Merged

[instantiation linking] create and import WASMMemoryInstance for aot #3887

merged 14 commits into from
Nov 20, 2024

Conversation

lum1n0us
Copy link
Collaborator

based on #3845

@lum1n0us lum1n0us force-pushed the feat_inst_linking_memory_aot branch 5 times, most recently from 9ef6ec2 to 730cd55 Compare November 1, 2024 13:00
@lum1n0us lum1n0us marked this pull request as ready for review November 1, 2024 13:35
This was referenced Nov 3, 2024
Merged
Open
Closed
wenyongh
wenyongh reviewed Nov 18, 2024
View reviewed changes
core/iwasm/aot/aot_loader.c Outdated Show resolved Hide resolved
core/iwasm/aot/aot_runtime.c Outdated Show resolved Hide resolved
core/iwasm/aot/aot_runtime.c Outdated Show resolved Hide resolved
core/iwasm/aot/aot_runtime.c Outdated Show resolved Hide resolved
core/iwasm/aot/aot_runtime.c Outdated Show resolved Hide resolved
core/iwasm/aot/aot_runtime.c Show resolved Hide resolved
core/iwasm/common/wasm_runtime_common.c Show resolved Hide resolved
core/iwasm/compilation/aot_emit_aot_file.c Show resolved Hide resolved
wenyongh
wenyongh reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had better test whether the AOT file compiled by older wamrc work in the new code?

core/iwasm/include/wasm_export.h Outdated Show resolved Hide resolved
core/iwasm/compilation/aot.c Outdated Show resolved Hide resolved
core/iwasm/compilation/aot_emit_aot_file.c Outdated Show resolved Hide resolved
core/iwasm/compilation/aot_emit_aot_file.c Outdated Show resolved Hide resolved
core/iwasm/compilation/aot_emit_aot_file.c Outdated Show resolved Hide resolved
@lum1n0us
Copy link
Collaborator Author

Had better test whether the AOT file compiled by older wamrc work in the new code?

Agreed. I intend to do that once all four WASMXXXInstance have been implemented. However, given the current progress, it is difficult to ensure compatibility starting from WASMGlobalInstance.

wenyongh
wenyongh approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lum1n0us lum1n0us merged commit 9b5058c into bytecodealliance:dev/instantiate_linking Nov 20, 2024
382 of 383 checks passed
@lum1n0us lum1n0us deleted the feat_inst_linking_memory_aot branch November 20, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyongh wenyongh wenyongh approved these changes

@loganek loganek Awaiting requested review from loganek loganek is a code owner

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

@xujuntwt95329 xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 is a code owner

@yamt yamt Awaiting requested review from yamt yamt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lum1n0us @wenyongh