Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move bytecode to app common to be configured at the top level #21

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jun 6, 2024

Move Bytecode "pointer to bytecode container image" to appcommon struct

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.36%. Comparing base (1861e30) to head (1f29e57).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   26.36%   26.36%           
=======================================
  Files          75       75           
  Lines        5112     5112           
=======================================
  Hits         1348     1348           
  Misses       3600     3600           
  Partials      164      164           
Flag Coverage Δ
unittests 26.36% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@anfredette anfredette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@mergify mergify bot merged commit f4caa07 into bpfman:main Jun 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants