run kind targets on the new repo #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msherif1234
force-pushed
the
fix_kind
branch
2 times, most recently
from
90ba1aa
to
53d3f24
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
===========================================
- Coverage 43.82% 26.38% -17.44%
===========================================
Files 18 75 +57
Lines 1716 5021 +3305
===========================================
+ Hits 752 1325 +573
- Misses 846 3532 +2686
- Partials 118 164 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
msherif1234
force-pushed
the
fix_kind
branch
9 times, most recently
from
a899de3
to
da52dac
Compare
astoycos
reviewed
May 30, 2024
Makefile
Outdated
| @@ -302,13 +302,13 @@ build-images: ## Build bpfman, bpfman-agent, and bpfman-operator images. | |||
| docker build -t ${BPFMAN_AGENT_IMG} -f Containerfile.bpfman-agent ./ | |||
|
|
|||
| .PHONY: push-images | |||
| push-images: ## Push bpfman, bpfman-agent, bpfman-operator images. | |||
| push-images: ## bpfman-agent, bpfman-operator images. | |||
There was a problem hiding this comment.
Suggested change
| push-images: ## bpfman-agent, bpfman-operator images. | |
| push-images: ## Push bpfman-agent, bpfman-operator images. |
Makefile
Outdated
|
|
||
| .PHONY: load-images-kind | ||
| load-images-kind: ## Load bpfman, bpfman-agent, and bpfman-operator images into the running local kind devel cluster. | ||
| docker pull ${BPFMAN_IMG} |
There was a problem hiding this comment.
No point in doing this, just remove locally loading the bpfman image
.github/workflows/pull_request.yml
Outdated
Comment on lines
81
to
83
| ## TODO(astoycos) Currently this is just done to ensure we have coverage | ||
| ## on all image builds. Ultimately we should be running the integration | ||
| ## tests with these locally built bytecode images. |
| @@ -0,0 +1,18 @@ | |||
| --- | |||
There was a problem hiding this comment.
Hrm so I don't think we should be duplicating all these here, let's talk more about the best way to install the example manifests when they live in their own repo, I'm thinking we could just maintain a static yaml and do something like
kustomize apply -k https://raw.githubusercontent.com/bpfman/bpfman/main/examples/config/base/go-xdp-counter/<FULL YAML>
msherif1234
force-pushed
the
fix_kind
branch
5 times, most recently
from
7d378ed
to
2712898
Compare
Signed-off-by: Mohamed Mahmoud <[email protected]>
Signed-off-by: Andrew Stoycos <[email protected]>
update a bunch of tooling around k8s code generators and fixup based on breaking changes reorganize client package a bit to remove redundancy Upgrade to go 1.22 Signed-off-by: Andrew Stoycos <[email protected]>
fix a logr panic in int tests make sure the unit test fake harness honors object sub-statuses Signed-off-by: Andrew Stoycos <[email protected]>
astoycos
force-pushed
the
fix_kind
branch
3 times, most recently
from
ff80baf
to
eb341c4
Compare
astoycos
approved these changes
May 31, 2024
astoycos
approved these changes
May 31, 2024
msherif1234
added a commit
to msherif1234/bpfman-operator
that referenced
this pull request
Oct 10, 2024
Fix operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixes #9 Thanks to @astoycos !!