This repository has been archived by the owner on Dec 2, 2020. It is now read-only.
Adding a wrap_java parameter to allow disabling use of the java.sh script #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 24, 2014 10:40
| source => 'puppet:///modules/java/java.sh', | ||
| mode => '0755', | ||
| require => Package['java'] | ||
| if $wrap_java { |
There was a problem hiding this comment.
Instead of a conditional, it's probably better to use the ensure parameter of the file resource. That way, if wrap_java = false, then the wrapper will get removed if it were there before.
There was a problem hiding this comment.
@loyal3-green-team If you can do this then we'll merge it.
|
is this a preferable alternative to #37 ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying DYLD_FALLBACK_LIBRARY_PATH caused problems for us, it would be nice to have the ability to use the plain java scripts.