Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDISCROWD-7781: Duplicate task check. Generate checksum #1000

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dchhabda
Copy link

Issue number of the reported bug or feature request: #

Describe your changes
A clear and concise description of the changes you have made.

Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.

Additional context
Add any other context about your contribution here.

@dchhabda dchhabda force-pushed the gen-checksum branch 2 times, most recently from 34e458c to 020f8d5 Compare November 19, 2024 15:40
@coveralls
Copy link

coveralls commented Nov 19, 2024

Pull Request Test Coverage Report for Build 11940610241

Details

  • 91 of 91 (100.0%) changed or added relevant lines in 3 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 94.106%

Files with Coverage Reduction New Missed Lines %
pybossa/view/projects.py 7 91.35%
Totals Coverage Status
Change from base Build 11920762966: 0.02%
Covered Lines: 17498
Relevant Lines: 18594

💛 - Coveralls

@dchhabda dchhabda force-pushed the gen-checksum branch 2 times, most recently from d1396a0 to bd57ba5 Compare November 20, 2024 17:38
Copy link

@n00rsy n00rsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@@ -184,6 +185,9 @@ def save(self, element, clean_project=True):
# set task default expiration
if element.__class__.__name__ == "Task":
element.expiration = get_task_expiration(element.expiration, make_timestamp())
checksum = generate_checksum(element)
print(checksum)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove print statement


dup_fields_configured = dup_task_config.get("duplicate_fields", [])
if not len(dup_fields_configured):
# include all task.info fields
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check does not do anything, can it be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants