-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDISCROWD-7781: Duplicate task check. Generate checksum #1000
base: main
Are you sure you want to change the base?
Conversation
34e458c
to
020f8d5
Compare
Pull Request Test Coverage Report for Build 11940610241Details
💛 - Coveralls |
d1396a0
to
bd57ba5
Compare
bd57ba5
to
6a18a61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@@ -184,6 +185,9 @@ def save(self, element, clean_project=True): | |||
# set task default expiration | |||
if element.__class__.__name__ == "Task": | |||
element.expiration = get_task_expiration(element.expiration, make_timestamp()) | |||
checksum = generate_checksum(element) | |||
print(checksum) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove print
statement
|
||
dup_fields_configured = dup_task_config.get("duplicate_fields", []) | ||
if not len(dup_fields_configured): | ||
# include all task.info fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check does not do anything, can it be removed?
Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.