FlashLoan: Allow mango ix after flash loan end #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lifts an unnecessary restriction, making it possible to do things like flash loan and then liquidate with the resulting balances in a single transaction. The "no mango ix after FlashLoanEnd" limitation was unnecessary: After the flash loan ends, the mango accounts are in a valid state again. And it's impossible to use a two FlashLoanEnd for a single FlashLoanBegin for the same reason that isolated FlashLoanEnds are rejected.
|
What's the reason for not allowing any other mango instructions in the middle of a flash loan? Naively, I'd think a major use case would be atomic liquidations like:
|
|
@Lou-Kamades Mango instructions during a flash loan make it very hard to reason about the safety. Currently we can be assured that no banks or vaults or accounts change state during the flash loan, simpllifying the flow a lot. We could relax that, but it'd need significant effort to make sure it's safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lifts an unnecessary restriction, making it possible to do things like flash loan and then liquidate with the resulting balances in a single transaction.
The "no mango ix after FlashLoanEnd" limitation was unnecessary: After the flash loan ends, the mango accounts are in a valid state again. And it's impossible to use a two FlashLoanEnd for a single FlashLoanBegin for the same reason that isolated FlashLoanEnds are rejected.