Updates about BitcoinCash #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR! I will make sure first that we run v0.18.8 then will merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format of address in genesis transaction for BitcoinCash has been legacy style like "1A1zP1eP5QGefi2DMPTfTL5SLmv7DivfNa", but should be CashAddr style like "bitcoincash:qp3wjpa3tjlj042z2wv7hahsldgwhwy0rq9sywjpyy" to be aligned with other BitcoinCash transactions.
https://cashaddr.bitcoincash.org
BitcoinCash node software has supported "getblock with verbosity = 2" option since v0.18.8.
https://github.com/Bitcoin-ABC/bitcoin-abc/releases/tag/v0.18.8
To gain ETL performance, "bitcoin_cash" should be removed from "HAVE_OLD_API" list in chain.py.