Geal/merge main in v5 #238
Conversation
* refactor(capi): Move CAPI generation to its own crate * reduce Biscuit visibility * remove capi.rs * add `print_block_source` c binding * add test for `biscuit_print_block_source` + use `inttypes.h` macros for handling cross-platform `uint64_t` type * remove `block()` usage and C-API usage
* do not build on x86 OSX * update readme * Apply suggestions from code review
CodSpeed Performance ReportMerging #238 will not alter performanceComparing Summary
|
Geal
force-pushed
the
geal/merge-main-in-v5
branch
from
dc83d3f
to
ed7cb5b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v5 #238 +/- ##
==========================================
- Coverage 69.03% 64.79% -4.24%
==========================================
Files 25 25
Lines 5926 6502 +576
==========================================
+ Hits 4091 4213 +122
- Misses 1835 2289 +454 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| @@ -2,69 +2,55 @@ name: Rust | |||
|
|
|||
| on: | |||
| push: | |||
| branches: [ main ] | |||
| branches: [main] | |||
There was a problem hiding this comment.
why not v5 as well? we run CI on all PRs targeting v5, but not on the v5 PR itself?
There was a problem hiding this comment.
good point. I think I need to fix this in a PR for main though
| @@ -0,0 +1,30 @@ | |||
| [package] | |||
| name = "biscuit-capi" | |||
| version = "5.0.0" # Should keep the same version as biscuit-auth | |||
There was a problem hiding this comment.
why all the spaces before the comments?
|
|
||
| [features] | ||
| default = [] | ||
| capi = ["inline-c"] |
There was a problem hiding this comment.
should the capi crate have an optional capi feature?
There was a problem hiding this comment.
I think that can be removed. inline-c is only used in the capi tests. I'll remove it in main first then port to v5
| @@ -0,0 +1,36 @@ | |||
| ## Biscuit C API | |||
|
|
|||
| This crate provides a C API for the Biscuit token library. It is a wrapper around the Rust API, and is intended to be used by other languages that can interface with C. | |||
There was a problem hiding this comment.
by C or other languages that can interface with C. If a language provides rust bindings through C (for instance Python with Maturin), it may be better to use that rather than this library.
|
I'll make a follow up PR to main to address those comments |
No description provided.