samples verify block by block #88
Conversation
KannarFr
force-pushed
the
verifyBlocks
branch
3 times, most recently
from
50fbfd3
to
fb4ae04
Compare
KannarFr
force-pushed
the
verifyBlocks
branch
4 times, most recently
from
a04ce68
to
e7a2e46
Compare
src/main/java/org/biscuitsec/biscuit/token/builder/parser/Parser.java
Outdated
Show resolved
Hide resolved
src/main/java/org/biscuitsec/biscuit/token/builder/parser/Parser.java
Outdated
Show resolved
Hide resolved
src/main/java/org/biscuitsec/biscuit/token/builder/parser/Parser.java
Outdated
Show resolved
Hide resolved
src/main/java/org/biscuitsec/biscuit/token/builder/parser/Parser.java
Outdated
Show resolved
Hide resolved
src/test/java/org/biscuitsec/biscuit/builder/parser/ParserTest.java
Outdated
Show resolved
Hide resolved
| SymbolTable sampleSymbols = new SymbolTable(sampleBlock.symbols); | ||
|
|
||
| Either<Map<Integer, List<org.biscuitsec.biscuit.token.builder.parser.Error>>, org.biscuitsec.biscuit.token.builder.Block> outputSample = Parser.datalog(sampleBlockIndex, baseSymbols, sampleDatalog); | ||
| assertTrue(outputSample.isRight()); |
There was a problem hiding this comment.
this should show the input that was parsed and the error we got, otherwise we don't have any context to fix it
| System.out.println(outputSample.get().build().print(sampleSymbols)); | ||
| System.out.println(block.symbols.symbols); | ||
| System.out.println(block.print(sampleSymbols)); | ||
| assertArrayEquals(outputSample.get().build().to_bytes().get(), block.to_bytes().get()); |
There was a problem hiding this comment.
same here, this should show the expected and actual arrays, because the errors don't help https://github.com/biscuit-auth/biscuit-java/actions/runs/8622173639/job/23632740026?pr=88#step:5:6259
|
BTW is there a good way in maven to capture stdout in tests, so that we only display it for tests that failed? |
Co-authored-by: Aurélien Mino <[email protected]>
Co-authored-by: Aurélien Mino <[email protected]>
|
#94 merges the parts of this PR that were already usable, leaving the samples block checks and the Right now I am not too convinced about the implementation of that method that does manual string manipulations. An implementation that follows the rest of the parser, using parser combinators, would fit better here and prevent errors. |
|
closing this since it has been merged as part of #102 |
This is DRAFT.