Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add block externalsignature in serialization #86

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

KannarFr
Copy link
Contributor

@KannarFr KannarFr commented Apr 3, 2024

No description provided.

@divarvel
Copy link
Collaborator

divarvel commented Apr 3, 2024

Serializing / Deserializing third-party blocks is rather tricky, but the conformance suite exercises the corner cases.

Please make sure that the test suite checks proper roundtrips and consistency with the conformance samples, in particular for test cases 24 and 26, and you should be ok.

@KannarFr
Copy link
Contributor Author

KannarFr commented Apr 3, 2024

@divarvel done in 033adff.

FWIW: with the added lines in tests, master failed on 24 & 26 and succeeded with this branch.

@Geal Geal merged commit 193d0a6 into biscuit-auth:master Apr 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants