Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use byte length for strings #92

Merged
merged 2 commits into from
Jul 5, 2024
Merged

fix: use byte length for strings #92

merged 2 commits into from
Jul 5, 2024

Commits on Jul 5, 2024

  1. fix: use byte length for strings 

    The spec has been clarified on how string length should be evaluated, see biscuit-auth/biscuit#159

tl;dr: string length is a minefield and no two languages do it consistently (and one could argue that no language does it properly).
Since cross-language compatibility is a core tenet of biscuit, let's do the thing that's guaranteed to work across languages: counting bytes in the utf8-encoded representation
    @divarvel
    divarvel committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    b00c939 View commit details
    Browse the repository at this point in the history

  2. hlint improvements

    @divarvel
    divarvel committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    4dc314c View commit details
    Browse the repository at this point in the history