Add Nix flake to biscuit-cli #56
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| { | ||
| inputs = { | ||
| flake-utils.url = "github:numtide/flake-utils"; | ||
| naersk.url = "github:nix-community/naersk"; | ||
| nixpkgs.url = "github:NixOS/nixpkgs/nixpkgs-unstable"; | ||
| }; | ||
|
|
||
| outputs = { self, flake-utils, naersk, nixpkgs }: | ||
| flake-utils.lib.eachDefaultSystem (system: | ||
| let | ||
| pkgs = import nixpkgs { | ||
| inherit system; | ||
| }; | ||
|
|
||
| naersk' = pkgs.callPackage naersk {}; | ||
|
|
||
| in rec { | ||
| # For `nix build` & `nix run`: | ||
| defaultPackage = naersk'.buildPackage { | ||
| src = ./.; | ||
| }; | ||
|
|
||
| # For `nix develop`: | ||
| devShell = pkgs.mkShell { | ||
| nativeBuildInputs = with pkgs; [ | ||
| cargo | ||
| clippy | ||
| libiconv | ||
| rustc | ||
| rustfmt | ||
| rust-analyzer | ||
| ]; | ||
| }; | ||
|
Comment on lines
+25
to
+33
There was a problem hiding this comment. Shouldn't we have the same shell in both the flake and the classic shell.nix? Note that one can There was a problem hiding this comment. This question might more to the core contributors than yourself @er4hn :) There was a problem hiding this comment. i don't really use the shell.nix anymore, feel free to harmonize as needed. |
||
| } | ||
| ); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered using the overlay provided by naersk directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is that? I'm not super familiar with Nix and used the naersk template suggested by their github repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overlays are a way to override packages definition (in a lazy recursive manner) but in that case they don't bring much. It would have let you extend the
pkgsto include ones provided by naersk and have it available withpkgs.naersk.In this case it doesn't matter and it's totally fine to stick to the official example.