Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactor and new client side individualization impl #14

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

MrDini123
Copy link

@MrDini123 MrDini123 commented Jul 21, 2019

Hi,

This PR wants to target the new client side individualization technique HBO uses for a week (or so) however I decided to refactor the code first. It's going to be a rather huge PR.

Planned things:

  • Fresh code style (better readability)
  • camelCase to underscore variables
  • instead of referencing dict keys directly, use dict.get() calls when necessary (partly done)
  • replace string concat with format strings
  • instead of global variables, maybe use hidden settings entries (feedback needed)
  • more flexible if syntax everywhere
  • rely on requests and drop urllib2 everywhere to make HTTP calls
  • new client side individualization

As always, any feedback is welcome

@MrDini123
Copy link
Author

MrDini123 commented Jul 21, 2019

Okay, that's it for now. I have decided not to take care of the uncomplete checkboxes yet in this PR since the whole listing would require a complete redesign. I plan to address those in a future PR. However after testing most things out everything seems to be working fine (tested under Windows x64; Kodi 18.3 & Kodi 18.2 LE; Raspberry Pi2 - however if you can, please try it on other devices).

Should be done for prod and up to you to merge or ask me to change if required.

PS: If this is going to be merged, please go for the squash merge method if possible. So all the commits will be converted into one large.

Thanks for this awesome addon!

@MrDini123 MrDini123 marked this pull request as ready for review July 21, 2019 22:44
@MrDini123 MrDini123 changed the title [WIP] Code refactor and new client side individualization impl Code refactor and new client side individualization impl Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant