Feat auth supported for clients #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
=========================================
- Coverage 49.47% 49.27% -0.2%
=========================================
Files 62 62
Lines 6280 6307 +27
=========================================
+ Hits 3107 3108 +1
- Misses 2826 2849 +23
- Partials 347 350 +3
Continue to review full report at Codecov.
|
wayslog
requested changes
Nov 27, 2019
| @@ -168,6 +169,13 @@ func (r *Request) IsSupport() bool { | |||
| return ok | |||
| } | |||
|
|
|||
| func (r *Request) IsAuth() bool { | |||
| if r.IsCtl() { | |||
There was a problem hiding this comment.
return r.IsCtrl() && bytes.Equal(r.resp.array[0].data, cmdAuthBytes)
| } else if bytes.Equal(reqData, cmdQuitBytes) { | ||
| req.reply.respType = respString | ||
| // general supported cmd need authorized | ||
| if !pc.authorized && !req.IsAuth() { |
There was a problem hiding this comment.
should not forward any command when pc.authorized is false. And so that authorized should be atomic flag or guard by mutex (be used by encoder/decoder together).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proxy supported AUTH cmd for clients