-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Website Styles #187
base: master
Are you sure you want to change the base?
Conversation
I’ll try to take a look at this and provide feedback by tomorrow, sorry for the wait. |
Thanks for the feedback!
This will likely be a pain point for me. Sans serif fonts demonstrably make for worse reading experiences over longer pieces. For small articles, it's completely fine, but anything longer will seriously hurt readability.
I threw together random colors, so I'm not deadset on anything specifically for the color scheme, but having light mode code on a dark mode website seems like an extraordinarily odd choice. My eyes are accustomed to reading text one way then immediately need to shift to adjust to the difference.
The changes I made in these departments also contribute to better legibility, but it's not enough to justify a change if you prefer the previous ones for branding. It's fine to keep the previous ones.
Are they? I'm not sure what you mean by that or how the screenshot demonstrates this. Previously, the link colors were the same color as the text. It looked like underlines for emphasis rather than a clickable link. Medium can get away with this because they make a deal of being black&white in the style of newspapers. The underlines are also thicker there than normal, which help.
Thanks! I do appreciate you taking time to respond! I'll likely see if I can create a chrome snippet to introduce the changes, so you can close PR. I was hoping to introduce the changes via the PR since others I've spoken to said along the same lines of my first comment, but I'll see if I can find another way. Again, thanks for taking the time! |
I really enjoyed reading the blog posts, but found it difficult to do so. These are changes that I think positively affect the readability, but it is of course subjective to some extent.