-
Notifications
You must be signed in to change notification settings - Fork 408
Fix #132 - Add Chrome Headless detection #145
Conversation
Add Chrome Headless support as Chrome browser to keep it simple for others to see as Chrome per Issue bestiejs#127.
Thank you @chiefcll! |
Thank you! - This is becoming more important with Chrome Headless playing a much larger role in CI systems. |
Thanks for the PR! I've only recently gotten back into open source, and will be looking at these commits later this week. What do you think about marking Chrome Headless differently from Chrome though? Should there be a |
I originally had the platform.name as 'Chrome Headless' but then changed it to Chrome due to seeing issue #127 - It might be better to have a |
Is any missing work preventing this from getting merged? I'd be happy to help. |
ps: I'd like to voice a preference to ferrying this forward and opening a follow-up. I think misidentifying |
e803c38
to
8c56eeb
Compare
bumping |
Hi all, sorry for the delay, working on merging some of the open PRs and releasing a new version soon. No firm promises, but expect a new version by the end of next week. |
Add Chrome Headless support as Chrome browser to keep it simple
for others to see as Chrome per Issue #127.