Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Fix #132 - Add Chrome Headless detection #145

Closed
wants to merge 2 commits into from

Conversation

chiefcll
Copy link
Contributor

Add Chrome Headless support as Chrome browser to keep it simple
for others to see as Chrome per Issue #127.

Add Chrome Headless support as Chrome browser to keep it simple
for others to see as Chrome per Issue bestiejs#127.
@jdalton
Copy link
Member

jdalton commented Jan 22, 2018

Thank you @chiefcll!

@chiefcll
Copy link
Contributor Author

Thank you! - This is becoming more important with Chrome Headless playing a much larger role in CI systems.

@bnjmnt4n
Copy link
Member

Thanks for the PR! I've only recently gotten back into open source, and will be looking at these commits later this week. What do you think about marking Chrome Headless differently from Chrome though? Should there be a platform.headless option in v2 for Chrome Headless, Phantomjs, and others? Looking for any opinions!

@chiefcll
Copy link
Contributor Author

I originally had the platform.name as 'Chrome Headless' but then changed it to Chrome due to seeing issue #127 - It might be better to have a platform.type which would then be mobile or headless. I'm not sure how many differences there are between Chrome + Headless + mobile as far as rendering and JS engine.

@omnibs
Copy link

omnibs commented Jul 16, 2018

Is any missing work preventing this from getting merged? I'd be happy to help.

@omnibs
Copy link

omnibs commented Jul 16, 2018

ps: I'd like to voice a preference to ferrying this forward and opening a follow-up.

I think misidentifying HeadlessChrome current as Safari 7 is more painful than not differentiating HeadlessChrome from Chrome properly.

@bnjmnt4n bnjmnt4n force-pushed the master branch 3 times, most recently from e803c38 to 8c56eeb Compare June 24, 2020 16:23
@kevinpthorne
Copy link

bumping

@bnjmnt4n
Copy link
Member

Hi all, sorry for the delay, working on merging some of the open PRs and releasing a new version soon. No firm promises, but expect a new version by the end of next week.

@bnjmnt4n bnjmnt4n closed this in a4c7a2d Jun 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

5 participants