Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with Dead Code Elimination feature #495

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Conversation

TharmiganK
Copy link
Contributor

@TharmiganK TharmiganK commented Nov 6, 2024

Purpose

$Subject

Part of: ballerina-platform/ballerina-library#7339

Obtained following error when running the tests with DCE feature:

error("No such record: ReadWriteZoneOffset")

This ReadWriteZoneOffset is a private record is used with the ValueCreator.createRecordValue API, to create a modifiable record value for the ZoneOffset record(this type is readonly).

There are few other usages of ValueCreator and TypeCreator. But since the referred types are already exposed in the external function call return type, they will be included by default.

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@TharmiganK TharmiganK added Skip GraalVM Check This will skip the GraalVM compatibility check and removed Skip GraalVM Check This will skip the GraalVM compatibility check labels Nov 6, 2024
Copy link

sonarcloud bot commented Nov 6, 2024

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.36%. Comparing base (cabfeb6) to head (0967806).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #495      +/-   ##
============================================
- Coverage     92.56%   92.36%   -0.21%     
  Complexity       62       62              
============================================
  Files            13       13              
  Lines           417      406      -11     
  Branches         93       93              
============================================
- Hits            386      375      -11     
  Misses           23       23              
  Partials          8        8              
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@D41311527 D41311527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@heshanpadmasiri heshanpadmasiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TharmiganK TharmiganK merged commit 1bb5302 into master Nov 6, 2024
11 checks passed
@TharmiganK TharmiganK deleted the fix-dce-errors branch November 6, 2024 08:37
TharmiganK added a commit that referenced this pull request Nov 18, 2024
[Revert] Fix issues with Dead Code Elimination feature #495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants