-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with Dead Code Elimination feature #495
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #495 +/- ##
============================================
- Coverage 92.56% 92.36% -0.21%
Complexity 62 62
============================================
Files 13 13
Lines 417 406 -11
Branches 93 93
============================================
- Hits 386 375 -11
Misses 23 23
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[Revert] Fix issues with Dead Code Elimination feature #495
Purpose
Part of: ballerina-platform/ballerina-library#7339
Obtained following error when running the tests with DCE feature:
error("No such record: ReadWriteZoneOffset")
This
ReadWriteZoneOffset
is a private record is used with theValueCreator.createRecordValue
API, to create a modifiable record value for theZoneOffset
record(this type is readonly).There are few other usages of
ValueCreator
andTypeCreator
. But since the referred types are already exposed in the external function call return type, they will be included by default.Examples
N/A
Checklist
Updated the changelogAdded testsUpdated the spec