Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle identifier quote in path segment #2225

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Handle identifier quote in path segment #2225

merged 3 commits into from
Nov 22, 2024

Conversation

TharmiganK
Copy link
Contributor

Purpose

Required for merging this PR: ballerina-platform/ballerina-lang#43630

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility
  • Checked the impact on OpenAPI generation

@TharmiganK TharmiganK added the Skip GraalVM Check This will skip the GraalVM compatibility check label Nov 22, 2024
@TharmiganK TharmiganK marked this pull request as ready for review November 22, 2024 05:49
Copy link

sonarcloud bot commented Nov 22, 2024

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (ee0b885) to head (af978cc).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...in/java/io/ballerina/stdlib/http/api/HttpUtil.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2225      +/-   ##
============================================
- Coverage     80.40%   79.84%   -0.56%     
- Complexity        0      678     +678     
============================================
  Files           366      417      +51     
  Lines         20704    23073    +2369     
  Branches       3284     3744     +460     
============================================
+ Hits          16647    18423    +1776     
- Misses         3126     3515     +389     
- Partials        931     1135     +204     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@TharmiganK TharmiganK merged commit 5e996a5 into master Nov 22, 2024
8 of 10 checks passed
@TharmiganK TharmiganK deleted the quote-identifier branch November 22, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip GraalVM Check This will skip the GraalVM compatibility check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants