Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hanging issue in the HTTP client after status code binding feature #1954

Merged
merged 4 commits into from
Apr 19, 2024

Merge branch 'master' into status-code-binding-fix

d07fa66
Select commit
Loading
Failed to load commit list.
Merged

Fix hanging issue in the HTTP client after status code binding feature #1954

Merge branch 'master' into status-code-binding-fix
d07fa66
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 19, 2024 in 0s

80.95% (target 80.00%)

View this Pull Request on Codecov

80.95% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 38.68613% with 168 lines in your changes are missing coverage. Please review.

Project coverage is 80.95%. Comparing base (b9e477a) to head (d07fa66).
Report is 1 commits behind head on master.

Files Patch % Lines
ballerina/http_status_code_client.bal 11.72% 128 Missing ⚠️
ballerina/http_status_code_client_object.bal 0.00% 24 Missing ⚠️
...b/http/api/nativeimpl/ExternResponseProcessor.java 83.33% 9 Missing and 1 partial ⚠️
ballerina/http_client_endpoint.bal 87.50% 4 Missing ⚠️
ballerina/http_response.bal 83.33% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1954      +/-   ##
============================================
- Coverage     81.55%   80.95%   -0.60%     
  Complexity      562      562              
============================================
  Files           387      389       +2     
  Lines         21401    21585     +184     
  Branches       4855     4969     +114     
============================================
+ Hits          17453    17475      +22     
- Misses         2951     3103     +152     
- Partials        997     1007      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov