Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Update query param resolving logic #1740

Merged

Conversation

dilanSachi
Copy link
Contributor

Purpose

$subject
Fixes ballerina-platform/ballerina-library#4705

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@dilanSachi dilanSachi marked this pull request as ready for review August 10, 2023 03:58
Copy link
Contributor

@TharmiganK TharmiganK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (00431a5) 81.56% compared to head (179b5a1) 81.61%.
Report is 1 commits behind head on 2201.7.x.

Additional details and impacted files
@@              Coverage Diff               @@
##             2201.7.x    #1740      +/-   ##
==============================================
+ Coverage       81.56%   81.61%   +0.04%     
  Complexity        577      577              
==============================================
  Files             393      393              
  Lines           21399    21399              
  Branches         4792     4792              
==============================================
+ Hits            17454    17464      +10     
+ Misses           2940     2937       -3     
+ Partials         1005      998       -7     
Files Changed Coverage Δ
...a/io/ballerina/stdlib/http/api/HttpDispatcher.java 83.65% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dilanSachi dilanSachi merged commit bbf9cc9 into ballerina-platform:2201.7.x Aug 10, 2023
6 checks passed
@dilanSachi dilanSachi deleted the fix-query-param-bug-7.x branch August 10, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants