Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix print content for -v -h & version for version -h as well #369

Conversation

Jaagrav
Copy link
Contributor

@Jaagrav Jaagrav commented Oct 19, 2024

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc.

When we run the bal -v -h command on any operating system, it will simply returns the ballerina version.

Ballerina Swan Lake Beta 6
Language specification 2021R1
Update Tool 1.3.7-rc1
However when we run the ballerina version -h command, it returns help window.

Closes #199

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Display version and ballerina information post help information when running bal -v -h or bal version -h or bal --version --help, etc.

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email [email protected] to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

Modify the bal shell file to print version and distribution info when executing the above mentioned commands.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Copy link

sonarcloud bot commented Oct 19, 2024

@Jaagrav
Copy link
Contributor Author

Jaagrav commented Oct 26, 2024

@keizer619 Please take a look

@NipunaMadhushan
Copy link
Contributor

@Jaagrav We have discussed about this issue internally and decided to show only the version info for any command below.
bal version -h
bal --version -h
bal -v -h
bal version --help
bal --version --help
bal -v --help

We made this decision as it has been the norm in most of other languages.

Can you please update the PR according to the requirement I mentioned above?

@keizer619 keizer619 changed the base branch from master to next-release November 4, 2024 05:29
@keizer619
Copy link
Member

As @NipunaMadhushan, we have some alterations. In that case we will merge this and do those changes iteratively

@keizer619 keizer619 merged commit fb0de7d into ballerina-platform:next-release Nov 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bal -v -h command does not open the help window
3 participants