Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default version to 0.0.0 #359

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Change default version to 0.0.0 #359

merged 3 commits into from
Aug 22, 2024

Conversation

NipunaMadhushan
Copy link
Contributor

@NipunaMadhushan NipunaMadhushan commented Aug 22, 2024 •
edited
Loading

Purpose

For user agent, we need a Ballerina version and this will change the default Ballerina version from empty string to 0.0.0.
This will fix the issue when we use only the ballerina-update-tool itself to pull a distribution.

Fixes #357

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email [email protected] to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

sm1990
sm1990 previously approved these changes Aug 22, 2024
View reviewed changes
keizer619
keizer619 reviewed Aug 22, 2024
View reviewed changes
src/main/java/org/ballerinalang/command/util/ToolUtil.java Outdated
@@ -93,6 +93,12 @@ public static String getCurrentBallerinaVersion() {
setInstallerVersion(installerVersionFilePath);
}
}
String ballerinaVersionFilePath = OSUtils.getBallerinaVersionFilePath();
if (!new File(ballerinaVersionFilePath).exists()) {
String defaultBallerinaVersion = "0.0.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets move this to constant and use everywhere

keizer619
keizer619 reviewed Aug 22, 2024
View reviewed changes
src/main/java/org/ballerinalang/command/util/ToolUtil.java Outdated
@@ -113,7 +119,7 @@ public static String getCurrentInstalledBallerinaVersion() {
return getVersion(OSUtils.getInstalledConfigPath());
} catch (IOException e) {
//If we files does not exist it will be empty and update tool continues without a distribution
return "";
return "0.0.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use constant here as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed suggestion.

keizer619
keizer619 reviewed Aug 22, 2024
View reviewed changes
src/main/java/org/ballerinalang/command/util/ToolUtil.java
@@ -93,6 +94,12 @@ public static String getCurrentBallerinaVersion() {
setInstallerVersion(installerVersionFilePath);
}
}
String ballerinaVersionFilePath = OSUtils.getBallerinaVersionFilePath();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using this variable right? Shall we avoid ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR. OSUtils.getBallerinaVersionFilePath() has been used in a below step as well.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@NipunaMadhushan NipunaMadhushan merged commit bfde5b2 into ballerina-platform:master Aug 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keizer619 keizer619 keizer619 approved these changes

@sm1990 sm1990 sm1990 left review comments

@hevayo hevayo Awaiting requested review from hevayo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set default Ballerina version to 0.0.0
3 participants
@NipunaMadhushan @keizer619 @sm1990