Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in readme change #43618

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

azinneera
Copy link
Contributor

@azinneera azinneera commented Nov 20, 2024

Purpose

Fix bugs in readme changes

Fixes #42981

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link
Contributor

@gayaldassanayake gayaldassanayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the indentation issue in L253

…ternal/ManifestBuilder.java

Co-authored-by: Gayal Dassanayake <[email protected]>
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.47%. Comparing base (ba7c74d) to head (71633ea).
Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
...o/ballerina/projects/internal/ManifestBuilder.java 75.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #43618      +/-   ##
============================================
- Coverage     77.48%   77.47%   -0.02%     
+ Complexity    58519    58514       -5     
============================================
  Files          3434     3434              
  Lines        218713   218720       +7     
  Branches      28918    28923       +5     
============================================
- Hits         169467   169448      -19     
- Misses        39850    39877      +27     
+ Partials       9396     9395       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@azinneera azinneera merged commit a7734cb into ballerina-platform:master Nov 21, 2024
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Add README.md as the primary documentation file for library packages
2 participants