Fix Resource access that are not ambiguous are reported as ambiguous access

[gimantha]

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #40606

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

• Read the Contributing Guide
• Updated Change Log
• Checked Tooling Support (#)
• Added necessary tests
  • Unit Tests
  • Spec Conformance Tests
  • Integration Tests
  • Ballerina By Example Tests
• Increased Test Coverage
• Added necessary documentation
  • API documentation
  • Module documentation in Module.md files
  • Ballerina By Examples

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.56%. Comparing base (8f7fe10) to head (d0b026e).
Report is 8 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master   #43589   +/-   ##
=========================================
  Coverage     77.55%   77.56%           
- Complexity    58742    58753   +11     
=========================================
  Files          3448     3448           
  Lines        219709   219735   +26     
  Branches      28915    28923    +8     
=========================================
+ Hits         170401   170430   +29     
+ Misses        39920    39909   -11     
- Partials       9388     9396    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rdulmina]

This will only handle the test case in the issue right? We need to handle the bellow cases as well
case1:

public client class SimpleClient {
    resource function get metadata/a() returns string {
        return "";
    }

    resource function get [string id]/a() returns string {
        return "";
    }
}

case2:

public client class SimpleClient {
    resource function get metadata/[string]() returns string {
        return "";
    }

    resource function get [string]/a() returns string {
        return "";
    }
}

sampleClient->/metadata/a; // which method to invoke. Should be give priority to first match in the path?

[gimantha]

Case 1 is handled by the fix. case 2 should be ambiguous, because both resource methods are candidates, right?

[rdulmina]

Yes, 2nd is ambiguous. Case one wont work if we change the order of the resource methods

[rdulmina]

public client class SimpleClient {
    resource function get [string]/a/[string]/c() returns string {
        return "";
    }
    resource function get metadata/[string]/b/c() returns string {
        return "";
    }

}
sampleClient->/metadata/a/b/c;

We need to think wether we give ambiguous error for this or not. Second resource method maches with three singleton types while first matches with only two. Hence should we pick the second from the compile time?

We also needs to add test to check wether the correct method is invoked and results are returned